]> dgit.raspbian.org Git - gnome-shell.git/commit
authPrompt: Fix spinner alignment
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 13 Apr 2020 16:55:34 +0000 (18:55 +0200)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Fri, 17 Apr 2020 22:35:31 +0000 (22:35 +0000)
commitb191e9ef9125b3e292b60a5db338f11a75794cc8
tree570906f3d2d6f57020dfb84b74147d2ab4e899e0
parent5ec5978d4ab75bbf7e01ce3e6b0968db0a486a6e
authPrompt: Fix spinner alignment

We want the spinner to be centered with regard to the entry, but
constraining the height breaks that:

 1. clutter_actor_allocate() is called with the available size
 2. clutter_actor_update_constraints() then adjusts that according
    to the constraints
 3. clutter_actor_adjust_allocation() applies the margin/expand/align
    properties.

The issue there is that 2. reduces the allocation to the desired size,
so there is no more extra space to distribute in 3.

We can fix this by either constraining everything (and rely on the
cancel button's alignment) or limit the constraint to the width. The
latter seems more appropriate, given that the constraint is only used
to center the entry horizontally.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2628
js/gdm/authPrompt.js